Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shorten DataRegion write-lock hold time during historical Pipe source startup while preserving startup lifecycle and history semantics.
start()synchronous.Example
Before: DataRegion 43 has 100,138 out-of-order files. Starting six Pipe historical sources scans and pins the history while holding the write lock, so concurrent writes wait about 18 seconds.
After: the lock covers the required flush and consistent snapshots; per-resource checks and pinning proceed after release, reducing write-lock occupancy while preserving historical filtering, ordering, and deletion handling.
Testing
mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanodepassed; zero files changed.mvn clean test -pl iotdb-core/datanode -am -Dtest=PipeHistoricalDataRegionTsFileAndDeletionSourceTest -Dsurefire.failIfNoSpecifiedTests=falsepassed; 31 tests.